Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Extract EF config from RulesContext #151

Open
2 tasks
jackreimers opened this issue Oct 27, 2023 · 0 comments
Open
2 tasks

♻️ Extract EF config from RulesContext #151

jackreimers opened this issue Oct 27, 2023 · 0 comments
Labels
Type: Refactor A code quality improvement e.g. Tech debt

Comments

@jackreimers
Copy link
Contributor

jackreimers commented Oct 27, 2023

Cc: @danielmackay

Hi

Pain

Currently all of the EF config is stored in the DbContext.
Dan suggested it should be moved out into a seperate class to keep the DbContext tidy as part of his review on #150.
The names of model classes should also have consistent suffixes, i.e. Model, Result or no suffix

Acceptance Criteria

The EF configuration code is extracted from RulesContext and the database access still works as expected.

Thanks!

Tasks

@jackreimers jackreimers added the Type: Refactor A code quality improvement e.g. Tech debt label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Refactor A code quality improvement e.g. Tech debt
Projects
None yet
Development

No branches or pull requests

1 participant