Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add GitHub ⭐️ star link and counter to SSW.Rules #1425

Closed
2 tasks done
tiagov8 opened this issue Aug 16, 2024 · 4 comments · Fixed by #1576
Closed
2 tasks done

✨ Add GitHub ⭐️ star link and counter to SSW.Rules #1425

tiagov8 opened this issue Aug 16, 2024 · 4 comments · Fixed by #1576
Labels
Type: Feature A suggested idea for this project

Comments

@tiagov8
Copy link
Member

tiagov8 commented Aug 16, 2024

Cc: @wicksipedia @adamcogan @jaydenalchin @bettybondoc
Email thread: SSW.Rules | “Star us”


Hi team,

Pain

as per @adamcogan , we want Rules to have the same feature "GitHub star" as Tina.io

Image

Suggested Solution

Add a top bar with the link and counter as per the mockup below

Image

Tasks

  • 1. Action

  • 2. On your "Done", include how many stars we have on the day it was implemented (mention @tiagov8)
    Current count when the Issue was created is 12

    Image

Thanks!


Note: The same is to be done on SSW.People: SSWConsulting/SSW.People#663

@tiagov8
Copy link
Member Author

tiagov8 commented Aug 16, 2024

Extra task:

  • 3. After the counter, add the sentence "We are migrating this site to TinaCMS"

@jaydenalchin
Copy link
Member

jaydenalchin commented Aug 19, 2024

CC @tiagov8 @wicksipedia @adamcogan @bettybondoc

For the record I don't think a whole new banner is necessary just for this link! ✨ Less is more ✨

The GitHub star CTA should be placed in the footer instead, without the extra text around it, especially if it's going to be common across our sites. In fact, Rules & People already have a similar CTA in the footer, which this should replace.

Image

Same applies to SSW People #663

@tiagov8
Copy link
Member Author

tiagov8 commented Sep 28, 2024

As per my conversation with @adamcogan we are adding this to the bottom in this area

Image

--

...using this text:

We ❤️ open source. Loving SSW Rules? ⭐️ us on GitHub {{ CONTROL WITH CURRENT STARS }}
Stand by... we are migrating this site to TinaCMS

bradystroud added a commit that referenced this issue Oct 16, 2024
Fixes #1425

Add GitHub star link and counter to the footer with specified text.

* Import `GitHubButton` from `react-github-btn` in `src/components/footer/footer.js`.
* Replace the existing GitHub link with the `GitHubButton` component.
* Update the footer text to include the specified text: "We ❤️ open source. Loving SSW Rules? ⭐️ us on GitHub {{ CONTROL WITH CURRENT STARS }} Stand by... we are migrating this site to TinaCMS".
* Install the `react-github-btn` package in `package.json`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/SSWConsulting/SSW.Rules/issues/1425?shareId=XXXX-XXXX-XXXX-XXXX).
@tiagov8 tiagov8 changed the title ✨ Add GitHub ⭐️ star link and counter to the top (SSW.Rules) ✨ Add GitHub ⭐️ star link and counter to SSW.Rules Oct 16, 2024
@bradystroud
Copy link
Member

bradystroud commented Oct 23, 2024

✅ Done

Check out the new footer on any page
https://www.ssw.com.au/rules/

Right now there are 14 stars - lets see if we get any more with this improved link 🙂

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature A suggested idea for this project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants