Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Fix Images extensions with capitalization #1431

Closed
1 task done
tiagov8 opened this issue Aug 27, 2024 · 4 comments
Closed
1 task done

♻️ Fix Images extensions with capitalization #1431

tiagov8 opened this issue Aug 27, 2024 · 4 comments
Assignees
Labels
Type: Refactor A code quality improvement e.g. Tech debt

Comments

@tiagov8
Copy link
Member

tiagov8 commented Aug 27, 2024

Converted to its own Issue since the rest of broken images not necessarily have this problem.

Original message from @RobJT-wq :

Setup - Do you use two monitors? | SSW.Rules

Can't seem to load this image in chrome/edge or firefox tried to edit in github/netlify as I thought the link might be broken but it shows in the markdown without any issues.

Any Ideas?

Image
Image


Then @tiagov8 fixed it by renaming the image from (TwoMonitorsBetterThanOne.JPG) to (two-monitors-better-than-one.jpg) in this PR: SSWConsulting/SSW.Rules.Content#9055


We want to avoid other occurances, so this comment was left on another Issue:

(Checked by @kikibianc )

As per my conversation with @tiagov8

Hi @bradystroud

It looks like capitalisation breaks image links SSWConsulting/SSW.Rules.Content#9055

  1. Can you find and rename the images with capitalisation?

Originally posted by @RobJT-wq in #8328

  • 1. Please find and fix all images that have capitalization in their file extensions.. e.g. JPG, PNG, GIF
@tiagov8
Copy link
Member Author

tiagov8 commented Aug 27, 2024

@bradystroud bradystroud removed their assignment Sep 3, 2024
@tiagov8
Copy link
Member Author

tiagov8 commented Sep 6, 2024

Another example of a broken image I had to fix by updating filename extension to lowercase SSWConsulting/SSW.Rules.Content#9116

@babakamyljanovssw
Copy link
Member

babakamyljanovssw commented Sep 20, 2024

cc: @bradystroud @JackDevAU @tiagov8

Update:

✅ Added logic to prevent merging PRs to SSW.Rules.Content repo with images that contains capital case extensions.
SSWConsulting/SSW.Rules.Content#9215

✅ Drafted new Issue #1490 for adding validation to image upload widget

As this PBI fixed images with capital extensions, I'm closing it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Refactor A code quality improvement e.g. Tech debt
Projects
None yet
Development

No branches or pull requests

3 participants