Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled tailwindcss rules in eslint and prettier #3417

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Enabled tailwindcss rules in eslint and prettier #3417

wants to merge 21 commits into from

Conversation

babakamyljanovssw
Copy link
Member

@babakamyljanovssw babakamyljanovssw commented Dec 17, 2024 •
edited
Loading

  1. Turned on tailwindcss/classnames-order in .eslintrc
  2. Added plugin prettier-plugin-tailwindcss and turned on it in .prettierrc
  3. Ran pnpm lint locally and found classname order warnings . Then fixed them using pnpm lint-fix

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🔴 Statements 0.19% 69/36052
🔴 Branches 6.14% 24/391
🔴 Functions 0.81% 3/370
🔴 Lines 0.19% 69/36052

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 914eb45

@babakamyljanovssw babakamyljanovssw changed the title ♻️ Enabled tailwindcss rules in eslint and prettier Draft - Enabled tailwindcss rules in eslint and prettier Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3417.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 74
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3417.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3417.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 52
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3417.azurewebsites.net

@babakamyljanovssw babakamyljanovssw removed the request for review from wicksipedia December 19, 2024 09:37
@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3417.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 79
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3417.azurewebsites.net

@babakamyljanovssw babakamyljanovssw changed the title Draft - Enabled tailwindcss rules in eslint and prettier Enabled tailwindcss rules in eslint and prettier Dec 20, 2024
@babakamyljanovssw babakamyljanovssw mentioned this pull request Dec 20, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-3417.azurewebsites.net

@github-actions GitHub Actions
Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 70
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3417.azurewebsites.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaaclombardssw isaaclombardssw Awaiting requested review from isaaclombardssw

@jeoffreyfischer jeoffreyfischer Awaiting requested review from jeoffreyfischer

@amankumarrr amankumarrr Awaiting requested review from amankumarrr

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Turn on the tailwindcss/classnames-order rule
1 participant
@babakamyljanovssw