Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing utility crate #254

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add testing utility crate #254

wants to merge 5 commits into from

Conversation

DanNixon
Copy link
Member

@DanNixon DanNixon commented Sep 24, 2024

Summary of changes

Adds a barebones testing utility crate (mostly stolen from Satori).

Resolves #253

Instruction for review/testing

  • review code, plz

@DanNixon DanNixon requested a review from Modularius September 24, 2024 12:37
@Modularius
Copy link
Contributor

Did some minor error handling improvements.

Is this intended to be called from a yet to be made binary? Or will this crate eventually be converted into one? In the former case the functions should return Results rather than panic before I approve, but in the latter case, I can approve as I imagine error handling would be done later.

@DanNixon
Copy link
Member Author

DanNixon commented Oct 2, 2024

Did some minor error handling improvements.

Since this code will only ever be used within tests it is technically exempt from the error handling style rules, although the changes are still for the better.

Is this intended to be called from a yet to be made binary?

It will be used by a suite of integration tests. It does not necessarily need to be it's own crate, that is just the route I went with in Satori.
On second consideration it is probably a better idea to just have this code inside the crate that will contain the tests.

@DanNixon
Copy link
Member Author

DanNixon commented Oct 2, 2024

Note that this is still work in progress (indicated by being a draft PR) please avoid modifying it for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port Satori integration testing utils
2 participants