You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've tested this change on a local clone of GaussianProcesses.jl with my own example, and it appears to work as intended. I have not run the tests in the test folder.
For consistency, I would also propose a change in line 28 from
results =optimize(func, init, args...; method=method, kwargs...) # Run optimizer
to
results =optimize(func, init, method, Optim.Options(;kwargs...)) # Run optimizer
One thing to note. It's unclear to me what role args... plays, so perhaps my proposed solution overlooks something.
The text was updated successfully, but these errors were encountered:
When calling
optimize!
withkernbounds != nothing
,kwargs...
is ignored.The relevant line appears to be 32 in the file optimize.jl.
The current line is
I would propose replacing it with
I've tested this change on a local clone of GaussianProcesses.jl with my own example, and it appears to work as intended. I have not run the tests in the test folder.
For consistency, I would also propose a change in line 28 from
to
One thing to note. It's unclear to me what role
args...
plays, so perhaps my proposed solution overlooks something.The text was updated successfully, but these errors were encountered: