Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent return values in auth functions #115

Open
der-gabe opened this issue Feb 6, 2023 · 1 comment
Open

Inconsistent return values in auth functions #115

der-gabe opened this issue Feb 6, 2023 · 1 comment

Comments

@der-gabe
Copy link
Member

der-gabe commented Feb 6, 2023

The function authenticated_user returns a User, while authorized_user returns a Callable, which in turn returns a User.

Such inconsistencies make both contributions and reviews more difficult and should be cleaned up.
@esskayesss
Copy link
Contributor

i agree with this issue. i have also encountered other instances where the way things have been named can end up being very confusing.

@esskayesss esskayesss mentioned this issue Jun 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@der-gabe @esskayesss