New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SWI-cpp2.h should be in a namespace #43

Open

kamahen opened this issue May 16, 2023 · 2 comments

Member

kamahen commented May 16, 2023

The reason is given here: https://google.github.io/styleguide/cppguide.html#Namespaces

This would require users of SWI-cpp2.h to add a "using namespace swi_cpp2;" or add "swi_cpp2::" to all references to items in SWI-cpp2.h.

Member

JanWielemaker commented May 17, 2023

Just swi?

Member Author

kamahen commented May 17, 2023

Namespace swi seems good to me. I'll prepare some PRs but I'm not in a hurry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment