Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Highlighting #53

Open
ian-andrich opened this issue Mar 16, 2017 · 4 comments
Open

Add Highlighting #53

ian-andrich opened this issue Mar 16, 2017 · 4 comments

Comments

@ian-andrich
Copy link

Please consider adding highlighting to the shared code editor in SWISH.

This will help when programmers are collaboratively editing code and just want to call attention to a piece of code.

@Anniepoo
Copy link
Member

Hmm.... you know, this could be abstracted to any piece of text, and extended to collaborative drawing (eg circling something).

@JanWielemaker
Copy link
Member

As yet, there is no shared editor. That is surely part of the plan. What exactly do you have in mind? Maybe associate the editor selection with a chat message? So you can select text, chat something about it and the chat message gets a button to show the corresponding selection? Ideally that means you should also be able to suggest a change. Possibly we can allow a user to perform local edits and send the diff as a chat?

@Anniepoo
Copy link
Member

well, This came out of my asking Ian to think of other use cases. He suggested shared highlighting. That seemed like a reasonable thing to stick in the pot - a way to select a block of code so you can say to the other programmer 'hey, this code has blah blah problem' and have them know what you mean.

@JanWielemaker
Copy link
Member

I think it is a promising idea. Would require something in CodeMirror that acts similar to the normal
selection but is distinct (I guess).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants