-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scoreLead display on graph #755
Comments
I like this feature and hope it could get merged. |
If you have a working solution, please submit it! I think we'd be definitely interested in merging a good implementation of this. |
Thanks! I'll clean up my implementation and send PRs in the order described above. |
@tibboh are you still planning to submit PRs for this issue? I found some issues with @zogwarg's #823 and am interested to see your implementation. In particular, I think you got the last point correct in your opening post, which is that the graph should only display one of the values (win rate or score lead) at a time. |
Hi, I didn't have time to clean up my code and probably won't be able to do this for the next month or so. I do think the graph should show the same metric that's shown on the board. |
Making the graph value type match the heatmap would require some design decisions regarding the "View" menu layout and keyboard shortcuts. I think it's reasonable to do it this way:
|
Even when the scoreLead display is chosen, the right-hand side graph displays winrate only. I propose changing it so that scoreLead is displayed instead (or in addition).
I have a working solution, which I'd like to polish and send a PR, if you like the idea. I imagine the following steps:
The text was updated successfully, but these errors were encountered: