Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add support for CzechRad CZRA1 header code #1034

Open
juhele opened this issue Sep 12, 2024 · 11 comments
Open

Please add support for CzechRad CZRA1 header code #1034

juhele opened this issue Sep 12, 2024 · 11 comments

Comments

@juhele
Copy link

juhele commented Sep 12, 2024

return false unless [

First prototype units used CZRDD, current CzechRads use CZRA1, in future possibly others like CZRA2, CZRB1 - this is because in case of commercial production of CzechRads there might be device number assignment conflicts if we had only CZRDD code.

thanks

References:
https://github.com/juhele/CzechRad/tree/main/DATA

@robouden
Copy link
Contributor

Jan,

To make the change in the code would be easy. But to get it deployed and in the app, we do not currently have anyone who is confident in doing that and who can allocate time for doing that. I would suggest making a change to use the old header till we can add your new header to the log file.

Regards
Rob

@juhele
Copy link
Author

juhele commented Sep 12, 2024

oops,
I think we will have to wait because we already have several hundreds of CzechRads in the field and there is no way to do such change remotely...

the only way would be to change it in every LOG file... (probably possible with some batch script) but reuploading those 700 LOGs looks like a nightmare...

@robouden
Copy link
Contributor

robouden commented Sep 12, 2024

Yes, we notice about 750 (according to Pieter). It would have been helpful if you had tested one upload only and see if that worked. BTW.. For the changing of the header in the batch file, you have to recalculate the chksum too.

Regards
Rob

@juhele
Copy link
Author

juhele commented Sep 12, 2024

I had the same issue at the beginning with the prototype data with old header so I thought you did not yet implemented it. Later, during uploading I noticed that old data is imported correctly but new not...

The checksum is not problem if I load and save the LOG from QGIS. However, both data types are displayed correctly in the API.
In addition the Tilemap is still not being updated yet so we have to wait anyway...

@robouden
Copy link
Contributor

robouden commented Sep 12, 2024 via email

@juhele
Copy link
Author

juhele commented Sep 12, 2024

RadiationToolbox handles the checksum when saving the LOG file. So you recommend to manually change the newly uploaded CzechRad LOGs to "legacy" header CZRDD to temporarily solve this issue? (until properly implemented) PS: I don't think it's within my time to redo the previously uploaded files as new measurements keep pouring in... And I think it it quite important to manage the quality control.

@robouden
Copy link
Contributor

Jan,

I will try one file and report back to you if that setup works. Please wait.

Regards
Rob

@robouden
Copy link
Contributor

Jan,

Just tested it and your idea works, see: https://api.safecast.org/en-US/bgeigie_imports/64632
Hugs and peace,
Rob

@robouden
Copy link
Contributor

robouden commented Sep 12, 2024

Jan,

I think you can also script a batch that can upload directly (from https://api.safecast.org):

image

@juhele
Copy link
Author

juhele commented Sep 15, 2024

OK,
a temporary solution consisting of manual conversion to legacy CzechRad code seems to work:
https://api.safecast.org/en-US/bgeigie_imports?by_user_id=6776&order=created_at+desc
I will use it for new data files, but I hope that after implementation into the API it will be possible to load (previously uploaded) files with the new CzechRad code in the future...

@robouden
Copy link
Contributor

Jan,

Thanks for using the temporal solution.
I also hope we can fix the issue soon.

Regards
Rob

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants