Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MenuItem - top/bottom padding added when contains node children #6934

Open
1 task done
johnb-sage opened this issue Sep 5, 2024 · 1 comment · May be fixed by #7017
Open
1 task done

MenuItem - top/bottom padding added when contains node children #6934

johnb-sage opened this issue Sep 5, 2024 · 1 comment · May be fixed by #7017
Labels
Bug On Backlog Squad Nebula

Comments

@johnb-sage
Copy link

johnb-sage commented Sep 5, 2024 •
edited by edleeks87
Loading

Description

Within MenuFullscreen additional top/bottom padding is being added to menu items that contain icons.

Screenshot 2024-09-05 at 10 48 22

Issue also present when Pill passed to item with href prop

image

Reproduction

MenuFullScreen
MenuItem with Pill and href

Steps to reproduce

Open fullscreen menu, inspect the menu items.

JIRA ticket numbers (Sage only)

SBS-108049

Suggested solution

No response

Carbon version

v142.9.0

Design tokens version

No response

Relevant browsers

Chrome

Relevant OSs

MacOS

Additional context

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@johnb-sage johnb-sage added Bug triage Triage Required labels Sep 5, 2024
@edleeks87 edleeks87 changed the title MenFullscreen - top/bottom padding added to menu items containing icons MenuItem - top/bottom padding added to containing node children Sep 5, 2024
@edleeks87 edleeks87 changed the title MenuItem - top/bottom padding added to containing node children MenuItem - top/bottom padding added when contains node children Sep 5, 2024
@nineteen88
Copy link
Contributor

FE-6798

@nineteen88 nineteen88 added On Backlog Squad Nebula and removed triage Triage Required labels Sep 10, 2024
edleeks87 added a commit that referenced this issue Oct 14, 2024
@edleeks87
fix(menu, menu-item): ensure that menu-items all remain the same heig…
aa673fd 
…ht if any wrap to new lines

Ensures that `MenuItem`s flex so that they all have the same height if any wrap their content to new
lines at smaller screen resolutions. Ensures no additonal padding is set on `MenuItem` children of
`MenuFullscreen`.

BREAKING CHANGE: `Menu` no longer supports `height`, `minHeight`, `maxHeight`, `size`,
`overflowY` and `display` props. `MenuItem` no longer supports `height`, `minHeight`,
`maxHeight`, `size`, `verticalAlign`, `overflow`, `overflowY`, `overflowX` and
`display` props.

fix #6934, fix #7000
edleeks87 added a commit that referenced this issue Oct 14, 2024
@edleeks87
fix(menu, menu-item): ensure that menu-items all remain the same heig…
aed7555 
…ht if any wrap to new lines

Ensures that `MenuItem`s flex so that they all have the same height if any wrap their content to new
lines at smaller screen resolutions. Ensures no additional padding is set on `MenuItem` children of
`MenuFullscreen`.

BREAKING CHANGE: `Menu` no longer supports `height`, `minHeight`, `maxHeight`, `size`,
`overflowY` and `display` props. `MenuItem` no longer supports `height`, `minHeight`,
`maxHeight`, `size`, `verticalAlign`, `overflow`, `overflowY`, `overflowX` and
`display` props.

fix #6934, fix #7000
@edleeks87 edleeks87 linked a pull request Oct 14, 2024 that will close this issue
Open
11 tasks
edleeks87 added a commit that referenced this issue Oct 16, 2024
@edleeks87
fix(menu, menu-item): ensure that menu-items all remain the same heig…
00c842b 
…ht if any wrap to new lines

Ensures that `MenuItem`s flex so that they all have the same height if any wrap their content to new
lines at smaller screen resolutions. Ensures no additional padding is set on `MenuItem` children of
`MenuFullscreen`.

BREAKING CHANGE: `Menu` no longer supports `height`, `minHeight`, `maxHeight`, `size`,
`overflowY` and `display` props. `MenuItem` no longer supports `height`, `minHeight`,
`maxHeight`, `size`, `verticalAlign`, `overflow`, `overflowY`, `overflowX` and
`display` props.

fix #6934, fix #7000
edleeks87 added a commit that referenced this issue Oct 18, 2024
@edleeks87
fix(menu, menu-item): ensure that menu-items all remain the same heig…
0c3caa4 
…ht if any wrap to new lines

Ensures that `MenuItem`s flex so that they all have the same height if any wrap their content to new
lines at smaller screen resolutions. Ensures no additional padding is set on `MenuItem` children of
`MenuFullscreen`.

BREAKING CHANGE: `Menu` no longer supports `height`, `minHeight`, `maxHeight`, `size`,
`overflowY` and `display` props. `MenuItem` no longer supports `height`, `minHeight`,
`maxHeight`, `size`, `verticalAlign`, `overflow`, `overflowY`, `overflowX` and
`display` props.

fix #6934, fix #7000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug On Backlog Squad Nebula
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Menu fixes Sage/carbon
2 participants
@johnb-sage @nineteen88