chore: update issue templates with typescript codesandbox links #6480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 34ae5b0:
|
robinzigmond
force-pushed
the
issue-template-update-csb
branch
from
d199842
to
b4fc6d3
Compare
edleeks87
previously approved these changes
Dec 8, 2023
Parsium
reviewed
Dec 8, 2023
| @@ -17,7 +17,8 @@ body: | |||
| label: Desired behaviour | |||
| description: | | |||
| Please give a clear and concise description of the desired behaviour. | |||
| If applicable, add screenshots or screen recording of a [CodeSandbox](https://codesandbox.io/s/carbon-quickstart-j5pb2) to help explain the request. You can paste these directly into GitHub. | |||
| If applicable, add screenshots or screen recording of a CodeSandbox to help explain the request. You can paste these directly into GitHub. | |||
| We provide Codesandbox templates with Carbon and dependencies pre-loaded, using either , using either [Typescript](https://codesandbox.io/p/sandbox/carbon-quickstart-typescript-6sjfuz) or [Javascript](https://codesandbox.io/p/sandbox/carbon-quickstart-j5pb2). | |||
There was a problem hiding this comment.
suggestion: think you have a typo here :)
Suggested change
| We provide Codesandbox templates with Carbon and dependencies pre-loaded, using either , using either [Typescript](https://codesandbox.io/p/sandbox/carbon-quickstart-typescript-6sjfuz) or [Javascript](https://codesandbox.io/p/sandbox/carbon-quickstart-j5pb2). | |
| We provide Codesandbox templates with Carbon and dependencies pre-loaded, using either [Typescript](https://codesandbox.io/p/sandbox/carbon-quickstart-typescript-6sjfuz) or [Javascript](https://codesandbox.io/p/sandbox/carbon-quickstart-j5pb2). |
The bug report and feature request templates contain links to our JS CSB template, but not to the TS one. We should provide this so it is easier for consumers to use Typescript in a codesandbox demonstrating their issue, if they wish to.
robinzigmond
force-pushed
the
issue-template-update-csb
branch
from
b4fc6d3
to
34ae5b0
Compare
edleeks87
approved these changes
Dec 8, 2023
Parsium
approved these changes
Dec 8, 2023
|
🎉 This PR is included in version 124.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug report and feature request templates contain links to our JS CSB template, but not to the TS one. We should provide this so it is easier for consumers to use Typescript in a codesandbox demonstrating their issue, if they wish to.
Proposed behaviour
Bug report/feature request templates should contain links to both JS and TS codesandbox templates.
Current behaviour
Only the JS one is linked to at the moment.
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions
The following CodeSandbox is an example of the broken behaviour.
You can see the new behaviour by looking at the version in the comment by
codesandbox[bot].