Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

找到关于padding填充的BUG #11

Open
lyric2y opened this issue Oct 18, 2022 · 0 comments
Open

找到关于padding填充的BUG #11

lyric2y opened this issue Oct 18, 2022 · 0 comments

Comments

@lyric2y
Copy link

lyric2y commented Oct 18, 2022

该项目似乎在padding填充出现问题。
首先第一处:https://github.com/SagerNet/cronet-go/blob/main/naive/main.go#L223 会引发网页空白,通过调试代码发现的。
发现该BUG是我编译项目后发现,代理页面访问空白。wireshark抓包发现请求可以到达服务器,但服务器似乎无法相应。于是我对项目进行debug,最后找到"Padding": generatePaddingHeader(),引起的,注释掉正常,但头部就没法填充了,作者能否找下原因所在?

第二处,代码的padding填充处理的无限递归问题,程序会突然崩溃!
https://github.com/SagerNet/cronet-go/blob/main/naive/main.go#L277-L282
无限递归处会引发程序崩溃,会出现Runtime: goroutine stack exceeds 1000000000-byte limit fatal error: stack overflow in ACM 溢出错误。并且填充后网页打开证书那些显示不安全,并且也是空白页面,可能填充逻辑需要改进。

作者能否修复下?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant