Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6 part expression parsing incompatible with parse-crontab #32

Open
eshmu opened this issue Jul 5, 2019 · 1 comment
Open

6 part expression parsing incompatible with parse-crontab #32

eshmu opened this issue Jul 5, 2019 · 1 comment

Comments

@eshmu
Copy link

eshmu commented Jul 5, 2019

The way this module parses 6 part Cron expressions is incompatible with other heavily used Python modules like parse-crontab.

For example, the following Expression "* * * * * *" is described as "Every second" while parse-crontab treats it as "Every minute". This is because parse-crontab assumes the 6th star in this case is the year (and thus the expression contains minutes, hours, ..., years), while this module requires a 4 digit number in that slot to make the same assumption (and otherwise, assumes this is an expression containing seconds).

I'd like to suggest adding an option that would adopt the parsing convention of parse-crontab and thus make this module more compatible with other Python modules.

I'm happy to make the change and submit a PR.

@Salamek
Copy link
Owner

Salamek commented Jul 6, 2019

@eshmu PRs are welcomed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants