Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWT Invalidation and Custom JWT Construction #100

Open
5 of 7 tasks
ChakshuGautam opened this issue Nov 19, 2024 · 1 comment · Fixed by #101
Open
5 of 7 tasks

JWT Invalidation and Custom JWT Construction #100

ChakshuGautam opened this issue Nov 19, 2024 · 1 comment · Fixed by #101

Comments

@ChakshuGautam
Copy link
Contributor

ChakshuGautam commented Nov 19, 2024

Description

There are currently two issues with JWTs

  • They are not invalidated post logouts
  • They are not validated centrally through an API
  • They cannot include custom fields that are configured as part of the application

Changes

Screenshot 2024-11-19 at 9 23 06 AM
  • @Amruth-Vamshi to create the JWT Store and APIs to validate/invalidate a JWT token. Can only be done through a valid JWT header for the same user. Parse the JWT to figure out the sub and use that to invalidate the token. Ensure all custom fields are added as part of the user metadata.
  • @KDwevedi to setup FA application JWT setting in such a way that custom fields (OTP, Phone, Fingerprint, Timestamp) are added as part fo the JWT.
  • @singhalkarun to setup a Caddy Module to validate certain APIs through this module. @KDwevedi to write the module code. | Deprioritized
  • @KDwevedi to setup AuthGuard to all relevant services. (BFF, TS)
  • @singhalkarun + Divij to deploy these changes to dev
  • @KDwevedi to setup E2E test case - bash script to test this out
  • Prateek to update the client to send all these params, and validate when the JWT comes back as a response, in failure cases - raise the appropriate error - "The user has been logged out, please login again". Raise a PR to the Kumbh frontend and get these merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants