Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Additional KV Data to Links #21

Open
Tracked by #52
ChakshuGautam opened this issue Jun 1, 2022 · 2 comments
Open
Tracked by #52

RFC: Additional KV Data to Links #21

ChakshuGautam opened this issue Jun 1, 2022 · 2 comments
Assignees
Labels

Comments

@ChakshuGautam
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Add any of your own key-value parameters to a yaus link.

@ChakshuGautam ChakshuGautam changed the title Spec for adding Deep Links RFC: Additional KV Data to Links Jun 1, 2022
@ChakshuGautam ChakshuGautam added the documentation Improvements or additions to documentation label Jun 1, 2022
@ChakshuGautam ChakshuGautam self-assigned this Jun 1, 2022
@ChakshuGautam ChakshuGautam added RFC and removed documentation Improvements or additions to documentation labels Jun 1, 2022
@Pankajjsuthar
Copy link

Can we say it as branded URLs like generally we use bitly as url shortener so their url look like bit.ly/_home_page/ but we want to look like personal_brand_name/home_page/_shortened_url

If I am thinking right then it would be an interesting problem to solve. Assign me this and I got a question that does it have a deadline of 10th June....

@Nazi-pikachu
Copy link
Collaborator

Hey @ChakshuGautam
For implementing the KV data feature. I and @yuvrajsab have been discussing these two possible implementation.
Can you please give your suggestions on this , it would be helpful to get a sense of what would be a better way to do this.

  1. Dynamically passon : In this way of implemting we are not storing the KV data in DB instead the liberty is with the user to pass any query params in the shorten link and it will get dynamically added to the long url as well.
  2. User specify allowed query params key at the time of registrations and then only allow those fields. (* to allow everything same as a pass on ).
    for ex :-
params: {
allowed : [ "$marketing" , ... ]
}

Also do we need to store the each KV data in the DB ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants