add connection for first part of reservation system for lyche #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hei98
reviewed
Feb 15, 2024
Comment on lines
+33
to
+35
| if (data.biggest_table == 0) { | ||
| toast.error('Det eksisterer ingen bord i backend'); | ||
| } else { |
There was a problem hiding this comment.
Antar dette bare er er for testing?
emilte
reviewed
Feb 15, 2024
| @@ -236,6 +238,20 @@ export async function getEventGroups(): Promise<EventGroupDto[]> { | |||
| return response.data; | |||
| } | |||
|
|
|||
| export async function getAvailableTimes(data: FetchAvailableTimesDto, pk?: number): Promise<string[]> { | |||
There was a problem hiding this comment.
Skal ikke optional parametre være etter non-optional?
There was a problem hiding this comment.
Hvorfor er den optional i det hele tatt?
There was a problem hiding this comment.
Det er noe som ikke stemmer med dette endepunktet
emilte
reviewed
Feb 15, 2024
| toast.error(t(KEY.common_something_went_wrong)); | ||
| console.error(error); | ||
| }); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
There was a problem hiding this comment.
Vi burde egt ikke ignorere disse
emilte
reviewed
Feb 15, 2024
| permission_classes = [AllowAny] | ||
|
|
||
| def get(self, request: Request) -> Response: | ||
| venue = self.request.query_params.get('venue', Venue.objects.get(slug='lyche').id) |
There was a problem hiding this comment.
Disse burde vi samle som konstanter et sted (lyche etc)
emilte
reviewed
Feb 15, 2024
| def get(self, request: Request) -> Response: | ||
| venue = self.request.query_params.get('venue', Venue.objects.get(slug='lyche').id) | ||
| biggest_table = Table.objects.filter(venue=venue).order_by('-seating').first() | ||
| return Response({'occasion': ReservationOccasion.choices, 'biggest_table': biggest_table.seating if biggest_table else 0}, status=status.HTTP_200_OK) |
There was a problem hiding this comment.
Suggested change
| return Response({'occasion': ReservationOccasion.choices, 'biggest_table': biggest_table.seating if biggest_table else 0}, status=status.HTTP_200_OK) | |
| biggest_seating = getattr(biggest_table, 'seating', 0) | |
| return Response({'occasion': ReservationOccasion.choices, 'biggest_table': biggest_seating}, status=status.HTTP_200_OK) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects check reservation, and reservation form with backend
Does not allow for posting yet