-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No Error catched for returned promise. #65
Comments
Even with updated version? Why does it silently exists? The destination should be created if it doesnt exists. |
Yes.
This is a pretty edge case as we've seem in the tests yesterday. But basically nope, |
Umpf it should throw an error in this case… And by |
That's what I think too.
The directory where the documentation will be generated. In the tests case |
No
.sassdoc
destination dir exist.env.theme('.sassdoc', env).catch(console.log); --> []
No
theme/assets
source dir exist.env.theme('.sassdoc', env).catch(console.log); --> []
fs-extra
dependency is0.1.0
which is pretty low, latest is0.16.3
.And in this version copy = ncp
There something screwed in the way ncp pass errors to callbacks.
Solution, uptate to
[email protected]
. At least there's an Error returned on source fail.fs-extra.copy
only error if the source is erroneous, if the destination does not exist it just silently exit.Solution, add a
fs.exist(dest)
test before ?The text was updated successfully, but these errors were encountered: