Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

sync_capsule_repos_to_upgrade task is quite dependant on nailgun #282

Open
ntkathole opened this issue Jan 29, 2019 · 3 comments
Open

sync_capsule_repos_to_upgrade task is quite dependant on nailgun #282

ntkathole opened this issue Jan 29, 2019 · 3 comments

Comments

@ntkathole
Copy link
Contributor

def sync_capsule_repos_to_upgrade(capsules):

Capsule repo sync uses nailgun which has a lot of variations in code/attributes between satellite versions.
The following issues need to fix or let's move back this task to CLI based.

  • Satellite6-upgrader jobs cant pick up nailgun version according to satellite version. (upgrade using this job is blocked. This job is useful for creating upgrade templates)
  • Zstream upgrade in pipeline needs to do manual changes. As nailgun is picked up according to "TO version". Thus, for 6.4 to 6.4.z upgrade, 6.4.z branch is used but actual nailgun code to be used will be in master.
@jyejare
Copy link
Member

jyejare commented Feb 6, 2019

satellite6-upgrade/upgrade/helpers/tasks.py

Line 72 in 6cfdfa8
def sync_capsule_repos_to_upgrade(capsules):

Capsule repo sync uses nailgun which has a lot of variations in code/attributes between satellite versions.
The following issues need to fix or let's move back this task to CLI based.

* Satellite6-upgrader jobs cant pick up nailgun version according to satellite version. (upgrade using this job is blocked. This job is useful for creating upgrade templates)

True, satellite6-upgrader needs updates with the latest changes, especially wrt nailgun. We can follow TO_VERSION and FROM_VERSION for installing nailgun and this strategy will work for all the versions except LATEST_SAT_VERSION, PREVIOUS_VERSION.
e.g if TO_VERSION='6.5' during upgrade, then we cant install nailgun#6.5.z as its not available. The available is master.
So there are two ways to fix it:

  1. Wait for nailgun to implement something like this Sat 6.5(latest) -> nailgun#6.5.z
  2. Keep a mapping of nailgun master and satellite somewhere in ci shell files or in the upgrade. I vote for ci.
* Zstream upgrade in pipeline needs to do manual changes. As nailgun is picked up according to "TO version". Thus, for 6.4 to 6.4.z upgrade, 6.4.z branch is used but actual nailgun code to be used will be in master.

As discussed, Implement in ci shell file like:
if ZSTREAM_UPGRADE:
install nailgun of FROM_VERSION before and after upgrade as well

@ntkathole
Copy link
Contributor Author

@jyejare This is still an issue.

@jyejare
Copy link
Member

jyejare commented Apr 16, 2019

Do we implement the above comment?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants