Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add asm-lsp #3516

Merged
merged 1 commit into from
Jan 14, 2024
Merged

feat: Add asm-lsp #3516

merged 1 commit into from
Jan 14, 2024

Conversation

WillLillis
Copy link
Contributor

Adds the schema for asm-lsp's config file

Related issue: bergercookie/asm-lsp#60

Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@hyperupcall
Copy link
Member

hyperupcall commented Jan 14, 2024

thank you - i saw bergercookie/asm-lsp#60 and was wondering if you meant to add asm-lsp.toml to the fileMatch array as well? otherwise ~/.config/asm-lsp/asm-lsp.toml would not match and it would not be detected automatically be the IDE.

@WillLillis
Copy link
Contributor Author

Hi! I originally just added .asm-lsp.toml to the fileMatch array as that is the name the program searches for, but in this context I think having both makes sense. Thanks so much for the suggestion!

Add asm-lsp.toml to fileMatch array
@hyperupcall
Copy link
Member

yay! thanks

@hyperupcall hyperupcall merged commit f96f22b into SchemaStore:master Jan 14, 2024
3 checks passed
@WillLillis WillLillis deleted the asm-lsp branch January 14, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants