Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding layout without message bubbles #5

Open
Reinachan opened this issue Jan 18, 2024 · 3 comments
Open

Consider adding layout without message bubbles #5

Reinachan opened this issue Jan 18, 2024 · 3 comments
Labels
design Design improvements/changes enhancement New feature or request upstream:feature A feature upstream used to have or are planning to add wontfix This will not be worked on

Comments

@Reinachan
Copy link

I'm not a big fan of message bubbles. I'd like there to be an option to make the layout similar to old Element when bubbles are disabled (modern layout as it's sometimes referred to as). I have my doubts upstream is interested in doing this, at least for the time being, so I'm suggesting it here too. My full request can be found here
element-hq/element-meta#2276

Is this something you'd be interested in adding support for?

@SpiritCroc
Copy link
Member

Is this something you'd be interested in adding support for?

No.
In fact, SchildiChat was born 50% because of (at the time being) lack of message bubbles in Element. So removing them is not something we're really interested in design wise.

While I'd like to say we're open to contributions for extra features that the user can configure, such features must be easily maintainable in the long run, and adding an additional layout will likely be tricky to implement in a way to satisfy this requirement. Realistically speaking, it will cause me lots of trouble for any timeline changes upstream does, so I'd say requirement would be implementing it in a way separated enough from the upstream code to allow

  1. Me to disable the code on upstream merges without any hassle, without breaking compile
  2. Any contributor who really wants to PR such feature to also maintain it in the long run
  3. Easy dropping of the code if it's no longer sustainable to maintain.

@SpiritCroc SpiritCroc added enhancement New feature or request wontfix This will not be worked on design Design improvements/changes labels Jan 18, 2024
@Reinachan
Copy link
Author

Fair enough. I can understand your reasoning. You can close this issue unless you want to keep it up in case someone else would pick it up. I'm not proficient in app development and am highly unlikely to PR this.

@cyrneko
Copy link

cyrneko commented Apr 7, 2024

That is on Element's roadmap anyways for both Element X clients.

@SpiritCroc SpiritCroc added the upstream:feature A feature upstream used to have or are planning to add label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design improvements/changes enhancement New feature or request upstream:feature A feature upstream used to have or are planning to add wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants