-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom emoji reactions per MXC URL #217
Comments
It's not "broken" as the matrix spec doesn't tell you that these should be rendered if they are matrix urls yet. So until the appropriate MSC is merged which proposed that MXC urls can be sent "custom" reactions, just rendering any text that there is is actually the "expected" behaviour. |
Could've sworn it used to be in SC web before.
…On Thu, 2 Nov 2023, 09:11 SpiritCroc ***@***.***> wrote:
It's not "broken" as the matrix spec doesn't tell you that these should be
rendered if they are matrix urls yet. So until the appropriate MSC is
merged which proposed that MXC urls can be sent "custom" reactions, just
rendering any text that there is is actually the "expected" behaviour.
Rendering such reaction MXCs has actually been implemented in
schildichat-desktop in
https://github.com/SchildiChat/matrix-react-sdk/commits/image-reactions-sumner
but hasn't found its way into a release yet.
—
Reply to this email directly, view it on GitHub
<#217 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFM522RB4PVTQFBX7YWUMY3YCNIS3AVCNFSM6AAAAAA6ZZ732OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJQGI2TINZWGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
+1 |
SC web 1.11.30-sc.2, reactions just show the cleartext.
The text was updated successfully, but these errors were encountered: