Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Run and Standard Run base classes to a single base class #405

Open
aanil opened this issue Jan 18, 2024 · 0 comments
Open

Merge Run and Standard Run base classes to a single base class #405

aanil opened this issue Jan 18, 2024 · 0 comments

Comments

@aanil
Copy link

aanil commented Jan 18, 2024

We have 2 base classes for Illumina runs, Run and Standard_Run. This is an artefact from when we only had MiSeq and Run dealt with only MiSeq runs. Standard_Run used to be HiSeq_Run which then inherited from the base MiSeq run class.

When there was a partial code cleanup and renaming of classes, the MiSeq specific methods were not moved to the new MiSeq_Run class.

We should move these methods to the MiSeq_Run class and merge the current Run and Standard_Run to create a generic base class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant