Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch from our findvars! to MTK's collect_vars! #1061

Open
isaacsas opened this issue Sep 20, 2024 · 2 comments
Open

switch from our findvars! to MTK's collect_vars! #1061

isaacsas opened this issue Sep 20, 2024 · 2 comments

Comments

@isaacsas
Copy link
Member

Since the latter is more likely to be updated as things change in MTK.
@isaacsas
Copy link
Member Author

#1077 gets us started by making it work on Reactions.

@isaacsas
Copy link
Member Author

isaacsas commented Nov 1, 2024 •
edited
Loading

This is done by #1104 modulo that there is no collect_vars! currently for events. So events still use our findvars!, but note this means they are not handling scoped variables consistent to collect_vars! (since we don't distinguish them in findvars!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@isaacsas