-
-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add input signals to build_explicit_observed_function
#2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baggepinnen
force-pushed
the
fb/beefy_observed
branch
from
June 26, 2023 09:21
e993eb8
to
7925285
Compare
Looks reasonable. Add a few tests. |
baggepinnen
force-pushed
the
fb/beefy_observed
branch
from
June 27, 2023 06:00
26e6164
to
5ee3cf7
Compare
The tests are failing on v1.6 due to RGF emitting an opaque closure. I deactivated the added tests on 1.6
|
Why would it generate a closure at all? |
No idea, but it did generate a closure that accessed the input. The generated code is working correctly though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds the possibility to specify input signals when building an observed function, this is useful for control systems. The resulting function signature will be
where$u$ are the inputs.
If this looks reasonable, I can add a few tests.