-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ANTLR with pure-Python alternative? #445
Comments
The antlr runtime is pure python. Is the objective to be able to re-generate the parser with pure Python? This seems like a lot of work for not much benefit. I see the fundamental concern with pinning to a specific version of antlr runtime - my guess is that we could support a version range, but I don't really know the compatibility guarantees of antlr. This will be the same problem for all users of the antlr runtime - perhaps we can follow the same approach used there (after all, ANTLR is popular). |
FWIW the testing of the parser is extensive. I have confidence that if the tests pass, the runtime is fine. Perhaps then the antlr runtime can be bumped through dependabot frequently? |
Yes but, to be clear, our major driver for this is the ongoing cost of maintaining the extra-python components, i.e. Cython and the resulting complicated build and installation mechanisms. There's a serious question here as to whether building our own solution could have similar problems, with tools such as a language parser being equally outside the experience of most of the team. But I'm hopeful that those parts would not change much and won't require much ongoing effort. |
Relates to #423 - well, it would render that unnecessary I suppose.
Would perhaps be part of the solution to having a pure-python cf-units - see #446
The text was updated successfully, but these errors were encountered: