Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slither.config.json to the template instead of hardcoding config params in the CI. #21

Open
re1ro opened this issue Sep 20, 2023 · 2 comments

Comments

@re1ro
Copy link

re1ro commented Sep 20, 2023

For more flexibility and being able to run slither with the same params locally and in CI.

Remove from CI:

slither-args: --filter-paths "./lib|./test" --exclude naming-convention,solc-version

Add slither.config.json to the template:

{
  "detectors_to_exclude": "naming-convention,solc-version",
  "filter_paths": "(./lib|./test)"
}
@mds1
Copy link
Contributor

mds1 commented Sep 20, 2023

I'm supportive of this, would you be willing to open a PR that makes this change?

@re1ro re1ro mentioned this issue Sep 21, 2023
2 tasks
@re1ro
Copy link
Author

re1ro commented Sep 21, 2023

PR is ready 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants