From 252c2585d687ed98bc5f7a6d00c322ce9f4da49e Mon Sep 17 00:00:00 2001 From: Ben DiFrancesco Date: Wed, 8 Nov 2023 16:57:36 -0500 Subject: [PATCH] Exclude the Governor from coverage reports & turn off slither for now --- .github/workflows/ci.yml | 42 ++++++++++++++++++++-------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7dde004..f978183 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -56,7 +56,7 @@ jobs: - name: Filter directories run: | sudo apt update && sudo apt install -y lcov - lcov --remove lcov.info 'test/*' 'script/*' --output-file lcov.info --rc lcov_branch_coverage=1 + lcov --remove lcov.info 'test/*' 'script/*' 'src/GuineaPigGovernor.sol' --output-file lcov.info --rc lcov_branch_coverage=1 # This step posts a detailed coverage report as a comment and deletes previous comments on # each push. The below step is used to fail coverage if the specified coverage threshold is @@ -101,23 +101,23 @@ jobs: scopelint --version scopelint check - slither-analyze: - runs-on: ubuntu-latest - permissions: - contents: read - security-events: write - steps: - - uses: actions/checkout@v3 - - - name: Run Slither - uses: crytic/slither-action@v0.3.0 - id: slither # Required to reference this step in the next step. - with: - fail-on: none # Required to avoid failing the CI run regardless of findings. - sarif: results.sarif - slither-args: --filter-paths "./lib|./test" --exclude naming-convention,solc-version - - - name: Upload SARIF file - uses: github/codeql-action/upload-sarif@v2 - with: - sarif_file: ${{ steps.slither.outputs.sarif }} + # slither-analyze: + # runs-on: ubuntu-latest + # permissions: + # contents: read + # security-events: write + # steps: + # - uses: actions/checkout@v3 + + # - name: Run Slither + # uses: crytic/slither-action@v0.3.0 + # id: slither # Required to reference this step in the next step. + # with: + # fail-on: none # Required to avoid failing the CI run regardless of findings. + # sarif: results.sarif + # slither-args: --filter-paths "./lib|./test" --exclude naming-convention,solc-version + + # - name: Upload SARIF file + # uses: github/codeql-action/upload-sarif@v2 + # with: + # sarif_file: ${{ steps.slither.outputs.sarif }}