Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve setup experience when user connects a Safe #547

Open
apbendi opened this issue Jun 26, 2023 · 3 comments
Open

Improve setup experience when user connects a Safe #547

apbendi opened this issue Jun 26, 2023 · 3 comments
Assignees
Labels
app A change related to the Umbra frontend enhancement New feature or request

Comments

@apbendi
Copy link
Member

apbendi commented Jun 26, 2023

As reported by a user:

I just connected with a smart contract wallet (Safe). I understand that "receive" and "setup" does not work because I need an EOA to sign.

This is likely correct—user's probably can't go through the setup process with a contract wallet like Safe—but we likely don't provide a good error message or explanation for them as to why. We should test this out to see what the experience is currently like and make improvements to it as warranted.

@apbendi apbendi added enhancement New feature or request app A change related to the Umbra frontend labels Jun 26, 2023
@apbendi apbendi added this to Umbra Jun 26, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Umbra Jun 26, 2023
@apbendi apbendi moved this from 🆕 New to 📋 Backlog in Umbra Jun 26, 2023
@alexkeating alexkeating self-assigned this Jun 27, 2023
@alexkeating
Copy link
Collaborator

When the user says they connected the safe what method did they use? I was able to setup up a safe on Umbra using wallet connect.

@alexkeating
Copy link
Collaborator

Let's add something similar to the argent warning about compatibility issues.

"Argent": {
  "warning": "Warning: Argent Compatibility Issues",
  "warning-paragraph": "<p class=\"text-bold\"> Umbra is not compatible with Argent's standard security model. While you can still use Umbra with Argent, you are at risk of losing funds if you switch devices or have to rely on social recovery without first withdrawing any funds sent to you via Umbra. </p> <p> Umbra works by generating app-specific keys derived from your wallet's private key. Argent is unique in that its security does not rely on your private key. This is good in many ways. </p> <p>When using Umbra, however, you must be aware of the following:</p> <ol> <li> If you recover your Argent wallet onto a new device, the new wallet will have the same address but a different private key. Unless you have access to the old device, funds sent via Umbra that you have not withdrawn will become unrecoverable. </li> <br /> <li> As a result, when you get a new device, you should withdraw all funds first using your old device, then repeat the Umbra account setup and re-publish your keys. Soon, the app will attempt to detect when you need to do this to minimize the chance of lost funds, but for now you must do it manually. </li> <br /> <li> Unlike other applications, the security of funds received by Umbra is not protected by the standard Argent security model, and instead they are just protected by your private key. </li> </ol>",
  "acknowledge-risks": "I acknowledge the risks"
},

@alexkeating
Copy link
Collaborator

Issue to keep in mind when adding functionality to open a modal when the connecting contract is a safe. safe-global/safe-smart-account#714

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app A change related to the Umbra frontend enhancement New feature or request
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants