Remove separate WithQuery to ensure it can be specified everywhere #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, move the with clause into insert/update/select/delete. Fixes SeaQL#813
|
Thank you for your contribution. While I appreciate now that we can use a with clause in all statement types, removing |
|
We could keep both kinds and deprecate WithQuery, removing it in a later version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, move the with clause into insert/update/select/delete. This makes sure you can specify with WITH clause to any method that takes a
SelectStatement/UpdateStatement/InsertStatement/DeleteStatement.PR Info
Breaking Changes
WithQueryand changes the signature of.with()