Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squeak loading fails due to STON #1420

Open
marschall opened this issue Jul 6, 2024 · 3 comments
Open

Squeak loading fails due to STON #1420

marschall opened this issue Jul 6, 2024 · 3 comments

Comments

@marschall
Copy link
Contributor

Our Squeak 5.3 and 6.0 CI tests fail because loading the packages fails with

^^^^^^^^^^^^^^^^^^ Warning: This package depends on the following classes:
  ZnUrl
  ZnMimeType
You must resolve these dependencies before you will be able to load these definitions: 
  ZnMimeType class>>fromSton:
  ZnMimeType class>>stonName
  ZnMimeType>>stonContainSubObjects
  ZnMimeType>>stonOn:
  ZnUrl>>stonContainSubObjects
  ZnUrl>>stonOn:
 ^^^^^^^^^^^^^^^^^^

Build was unable to report intermediate build status.

It looks like we're trying to load STON for Parasol and Parasol is loaded because 'Seaside-Tests-Parasol' is part of 'Tests'.

STON has a dependency on Zinc which is not declared. This works in Pharo where Zinc is already present but fails on Squeak.

I filed svenvc/ston#43

@jbrichau
Copy link
Member

Zinc will actually not work in Squeak, as far as I know. It is even doubtful that STON works in Squeak.. so unless someone will start porting and maintaining those two projects for Squeak (doubtful), perhaps we should rather aim to remove the functional tests using Parasol from the Squeak build?

Moreover, Parasol uses STON to read and write JSON... which should be unnecessary imho. I think that should be replaced with Seaside-Json.

@jbrichau
Copy link
Member

I added a PR on Parasol to remove the dependency on STON: SeasideSt/Parasol#68

@marschall
Copy link
Contributor Author

Zinc will actually not work in Squeak, as far as I know. It is even doubtful that STON works in Squeak.. so unless someone will start porting and maintaining those two projects for Squeak (doubtful), perhaps we should rather aim to remove the functional tests using Parasol from the Squeak build?

Yeah I think that makes sense.

Moreover, Parasol uses STON to read and write JSON... which should be unnecessary imho. I think that should be replaced with Seaside-Json.

I think that makes sense as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants