Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to disable changing search engines by scrolling on the search bar #21

Open
the-blank-x opened this issue Aug 19, 2023 · 0 comments · May be fixed by #23
Open

Add an option to disable changing search engines by scrolling on the search bar #21

the-blank-x opened this issue Aug 19, 2023 · 0 comments · May be fixed by #23
Assignees
Labels
enhancement New feature or request

Comments

@the-blank-x
Copy link

the-blank-x commented Aug 19, 2023

From a feature request I filed:

It seems like you can change your default search engine by scrolling on the search bar (in my experience, this has only worked if I pinch/zoom on the bar). I tend to magnify pages with small text by pinching to zoom on my touchpad. If the cursor happens to be on the search bar, I would accidentally change my search engine and have to go to settings to change it back to my preferred engine. It doesn't seem like I can disable this functionality, hence this feature request/idea.

Looks like this functionality is in browser/omni.ja, more specifically chrome/browser/content/browser/search/searchbar.js:

this.addEventListener(
  "DOMMouseScroll",
  event => {
    if (event.getModifierState("Accel")) {
      this.selectEngine(event, event.detail > 0);
    }
  },
  true
);

It also seems like this happens when you scroll while holding Control (source)

@the-blank-x the-blank-x added the enhancement New feature or request label Aug 19, 2023
the-blank-x added a commit to the-blank-x/firefox-omni-tweaks that referenced this issue Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants