From 05e5b410b85e13e44317fde604abb74829f64cdc Mon Sep 17 00:00:00 2001 From: stevekaplan123 Date: Mon, 31 Jul 2023 14:42:44 +0300 Subject: [PATCH 1/2] fix(Source Editor): remove generatedBy --- sefaria/helper/topic.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sefaria/helper/topic.py b/sefaria/helper/topic.py index 733003eba8..191cdc42f3 100644 --- a/sefaria/helper/topic.py +++ b/sefaria/helper/topic.py @@ -1070,6 +1070,9 @@ def edit_topic_source(slug, orig_tref, new_tref="", creating_new_link=True, current_descriptions[interface_lang] = description link.descriptions = current_descriptions + if getattr(link, 'generatedBy', TopicLinkHelper.generated_by_sheets): + del link.generatedBy + if not creating_new_link and link is None: return {"error": f"Can't edit link because link does not currently exist."} elif creating_new_link: From dce8cf4d5124d19d04c19f0d1af0b2da0c2a8af4 Mon Sep 17 00:00:00 2001 From: stevekaplan123 Date: Fri, 11 Aug 2023 02:58:19 +0300 Subject: [PATCH 2/2] fix(Source Editor): generatedBy isn't always present but previous code assumed it was --- sefaria/helper/topic.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sefaria/helper/topic.py b/sefaria/helper/topic.py index 191cdc42f3..ac3095ef79 100644 --- a/sefaria/helper/topic.py +++ b/sefaria/helper/topic.py @@ -1014,7 +1014,6 @@ def update_topic(topic_obj, **kwargs): topic_obj.save() - if kwargs.get('rebuild_topic_toc', True): rebuild_topic_toc(topic_obj, orig_slug=orig_slug, category_changed=(old_category != kwargs.get('category', ""))) return topic_obj @@ -1070,8 +1069,8 @@ def edit_topic_source(slug, orig_tref, new_tref="", creating_new_link=True, current_descriptions[interface_lang] = description link.descriptions = current_descriptions - if getattr(link, 'generatedBy', TopicLinkHelper.generated_by_sheets): - del link.generatedBy + if hasattr(link, 'generatedBy') and getattr(link, 'generatedBy', "") == TopicLinkHelper.generated_by_sheets: + del link.generatedBy # prevent link from getting deleted when topic cronjob runs if not creating_new_link and link is None: return {"error": f"Can't edit link because link does not currently exist."}