Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Somethings Crafters may not push the correct item #190

Open
balugaq opened this issue Jul 11, 2024 · 1 comment
Open

Somethings Crafters may not push the correct item #190

balugaq opened this issue Jul 11, 2024 · 1 comment

Comments

@balugaq
Copy link

balugaq commented Jul 11, 2024

If we have two very similar but different recipes like
Item A:
RRR
RUR
RRR

Item B:
RRR
R R
RRR

R and U are real items.
And you can see that they only have one difference.
If we made a blueprint of Item A. And let it works in Crafters.
And we have only R in the networks.
Then the Crafters will make Item B instead of not working.

From SlimefunGuguProject#116

@balugaq
Copy link
Author

balugaq commented Jul 11, 2024

Some insights from that issue.

136b1c40d7666a15f2650afe371e5355

Translation:

Finally, I found the reason.
NetworkRoot rebuilds each slimefun tick during its lifecycle.
The NetworkRoot.getBarrels() called during the for loop in NetworkRoot.getItemStack() will only be initialized once, and in all other cases, it will directly return the ready-made value.
However, modifying quantum storage within the current slimefun tick does not modify the data in the Barrels list, leading to issues.
All other components directly traverse the blockMenu object, so there won't be any issues.
Ask a insider to fix this thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant