Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to prettier #353

Closed
corevo opened this issue Aug 20, 2018 · 1 comment
Closed

Move to prettier #353

corevo opened this issue Aug 20, 2018 · 1 comment

Comments

@corevo
Copy link
Member

corevo commented Aug 20, 2018

🚀 Feature Proposal

Move to an automatic code formatter, like prettier.

Motivation

Currently contributors and maintainers have to manually format their code according to eslint's rules, prettier's spirit is to format the code for you automatically.
Prettier supports almost all of the code editors out there.

When?

Since changing the linter will cause re-linting of all source files, it will create conflicts for all pending prs, I will finish up with old ones like #139 and #144, I don't currently see a way for #228 and #230 to make it in.
But we should probably make sure #220 and #241 make it in soon.

@tourdedave
Copy link
Contributor

This looks to be done in 2b2be50. @corevo, good to close?

@corevo corevo closed this as completed Jan 10, 2019
@lock lock bot locked and limited conversation to collaborators Aug 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants