-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to sync videos? #6
Comments
I just found your extension and it works incredibly well, thank you very much for that! |
Yes, using ad-blocking extensions may improve user experience. |
Yes. For some sites everyone get's a different url, so the second approach would work there. |
I know I'm late to the party, but I have an approach that might be of interest: Have a tab-specific "sync_tab" variable hooked up to a checkbox. This enables users to manually work around any url differences, and, with some other minor tweaks, could support syncing videos across tabs of the same browser (e.g. for separate commentary on a video). Could use current logic for determining which tab is selected by default. This doesn't affect how you choose within a tab. Could be interested in helping out on this when I have some time. Haven't quite grocked the structure of this repo yet. |
add lazy nginx.conf copy in Dockerfile
According to statistics, about 25% of users that uninstalled the extension have some problems with synchronization.
The current implementation of defining and syncing videos uses:
strict URL comparison of the syncing tab between users in the room.EDIT: fix: drop url strict comparison #47This is complicated, but I remember why I did it like that.
Problems of this implementation:
If one of the users in the room will have a little bit different URL, for example, GET request then synchronization will not work.Another way to implement video sync?
Each user in the room must choose what tab to sync, then start video which he wants to sync. It adds a lot of manual steps, but guarantee that video will be in sync.
Please give other ideas on how to sync video.
The text was updated successfully, but these errors were encountered: