Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert css files to sass and refactor code #61

Closed
miggs125 opened this issue Jun 2, 2019 · 9 comments · Fixed by #124
Closed

convert css files to sass and refactor code #61

miggs125 opened this issue Jun 2, 2019 · 9 comments · Fixed by #124
Assignees
Labels
area: frontend help wanted Extra attention is needed type: enhancement New feature or request

Comments

@miggs125
Copy link
Contributor

miggs125 commented Jun 2, 2019

The style files are, specifically App.css is getting rather large and needs to be refactored and modulated in order to keep the codebase maintainable as the project scales

@miggs125 miggs125 added type: enhancement New feature or request help wanted Extra attention is needed labels Jun 2, 2019
@Silvyre
Copy link

Silvyre commented Oct 6, 2019

Hello,

I am a Seneca student currently taking Topics in Open Source Development. I have chatted with my professor (@humphd) about contributing to an OSTEP repository for Hacktoberfest, and working on this issue for the OSTEP dashboard seems like a great opportunity to do so.

If possible, may I request permission to work on this issue? I would alternatively be happy to drop by CDOT in person to chat more about how I may help out.

Thank you very much,

Rafi

@humphd
Copy link

humphd commented Oct 7, 2019

cc @manekenpix and @miggs125, who are both in my open source class, and also work or have worked in this repo as well. Perhaps one of you can help guide @manekenpix so he can contribute too?

@poftadeh
Copy link
Contributor

poftadeh commented Oct 7, 2019

@Silvyre feel free to take on this issue for Hacktoberfest.

@Silvyre
Copy link

Silvyre commented Oct 7, 2019

Thank you very much, everyone! I look forward to working with you!

@manekenpix
Copy link
Member

@humphd yes, no problem. @Silvyre let us know if there's anything we can help you with.

@miggs125
Copy link
Contributor Author

miggs125 commented Oct 7, 2019

@Silvyre feel free to take it, I started working on it some time ago on this branch. Some of the content on the branch may be outdated. It's been a while since I worked on it.

@Silvyre
Copy link

Silvyre commented Oct 7, 2019

@manekenpix @miggs125 Thank you! I'll certainly be in touch!

@Silvyre
Copy link

Silvyre commented Oct 10, 2019

Thanks to the help of @miggs125, I have been able to successfully run the OSTEP Dashboard locally via npm run-scriptdebug.

Within the next three weeks, I plan to apply the knowledge I am gaining from a Udemy course (also recommended by @miggs125) to finish the work started on the issues/61-convert-css-to-sass branch.

@poftadeh
Copy link
Contributor

@Silvyre good to hear. I've changed #10 to an open help wanted issue as well if you're in need of more contributions toward Hacktoberfest. It's a relatively small starter issue that you or anyone else from @humphd 's class are free to take on if interested.

blueocto pushed a commit to blueocto/ostep-dashboard that referenced this issue May 6, 2020
* It uses Gulp for processing Node Sass
* I've split the headings into partials, and call them in app.scss which is output to css/app.css
* You need to run `gulp sass` for it to compile
manekenpix added a commit that referenced this issue Aug 8, 2020
Convert css files to sass and refactor code #61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend help wanted Extra attention is needed type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants