Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soulcalibur weird single vertex strips #12

Open
Senryoku opened this issue Feb 8, 2024 · 0 comments
Open

Soulcalibur weird single vertex strips #12

Senryoku opened this issue Feb 8, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Senryoku
Copy link
Owner

Senryoku commented Feb 8, 2024

Soulcalibur sometimes pushes single vertex with the end of strip flag, very easy to trigger by playing Taki. I don't know if ignoring them in the renderer actually causes any issue, but this might be the symptom of another issue, as the vertex parameters look fine otherwise.

Some logs:

Previous Command: 
holly.ParameterControlWord{ .obj_control = holly.ObjControl{ .uv_16bit = 0, .gouraud = 0, .offset = 0, .texture = 0, .col_type = holly.ColorType.PackedColor, .volume = 0, .shadow = 0, ._ = 0 }, .group_control = holly.GroupControl{ .user_clip = holly.UserClipUsage.Disable, .strip_len = 0, ._ = 0, .en = 0 }, .list_type = holly.ListType.Opaque, ._ = 0, .end_of_strip = 1, .parameter_type = holly.ParameterType.VertexParameter }
(Command Buffer, only the first 8 u32 were actually used)
  F0000000
  4310651F
  43941F1A
  3E3E7CD9
  3EBD0F5F
  3EDF6000
  FFFFFF96
  00191D00
  43F00000
  45505000
  00000000
  43F00000
  FF000000
  00000000
  00000000
  00000000

Previous Vertex Parameter:

holly.VertexParameter{ .Type3 = holly.VertexParameter_3{
 .parameter_control_word = holly.ParameterControlWord{ .obj_control = holly.ObjControl{ .uv_16bit = 0, .gouraud = 0, .offset = 0, .texture = 0, .col_type = holly.ColorType.PackedColor, .volume = 0, .shadow = 0, ._ = 0 }, .group_control = holly.GroupControl{ .user_clip = holly.UserClipUsage.Disable, .strip_len = 0, ._ = 0, .en = 0 }, .list_type = holly.ListType.Opaque, ._ = 0, .end_of_strip = 1, .parameter_type = holly.ParameterType.VertexParameter },
.x = 1.44395004e+02, .y = 2.96242980e+02, .z = 1.86023131e-01, .u = 3.69257897e-01, .v = 4.36279296e-01, .base_color = holly.PackedColor{ .b = 150, .g = 255, .r = 255, .a = 255 }, .offset_color = holly.PackedColor{ .b = 0, .g = 29, .r = 25, .a = 0 } } }

First Problematic Vertex Parameter:

holly.VertexParameter{ .Type3 = holly.VertexParameter_3{
 .parameter_control_word = holly.ParameterControlWord{ .obj_control = holly.ObjControl{ .uv_16bit = 0, .gouraud = 0, .offset = 0, .texture = 0, .col_type = holly.ColorType.PackedColor, .volume = 0, .shadow = 0, ._ = 0 }, .group_control = holly.GroupControl{ .user_clip = holly.UserClipUsage.Disable, .strip_len = 0, ._ = 0, .en = 0 }, .list_type = holly.ListType.Opaque, ._ = 0, .end_of_strip = 1, .parameter_type = holly.ParameterType.VertexParameter },
.x = 1.51825042e+02, .y = 2.94236816e+02, .z = 1.84038162e-01, .u = 4.08437669e-01, .v = 4.36279296e-01, .base_color = holly.PackedColor{ .b = 149, .g = 255, .r = 255, .a = 255 }, .offset_color = holly.PackedColor{ .b = 0, .g = 27, .r = 24, .a = 0 } } }

Next Vertex Parameter:

holly.VertexParameter{ .Type3 = holly.VertexParameter_3{
 .parameter_control_word = holly.ParameterControlWord{ .obj_control = holly.ObjControl{ .uv_16bit = 0, .gouraud = 0, .offset = 0, .texture = 0, .col_type = holly.ColorType.PackedColor, .volume = 0, .shadow = 0, ._ = 0 }, .group_control = holly.GroupControl{ .user_clip = holly.UserClipUsage.Disable, .strip_len = 0, ._ = 0, .en = 0 }, .list_type = holly.ListType.Opaque, ._ = 0, .end_of_strip = 1, .parameter_type = holly.ParameterType.VertexParameter },
.x = 1.44395004e+02, .y = 2.96242980e+02, .z = 1.86023131e-01, .u = 3.69257897e-01, .v = 4.36279296e-01, .base_color = holly.PackedColor{ .b = 150, .g = 255, .r = 255, .a = 255 }, .offset_color = holly.PackedColor{ .b = 0, .g = 29, .r = 25, .a = 0 } } }
@Senryoku Senryoku added the bug Something isn't working label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant