From 3b456830a9243f8ddd2679a7c89634b0b743fbde Mon Sep 17 00:00:00 2001
From: Serge Tupchii <serge.tupchii@protonmail.com>
Date: Wed, 27 Mar 2024 19:58:32 +0200
Subject: [PATCH] feat: add API to disable/enable core node discovery

This can be used to prevent a replicant node from re-joining the same cluster after it has (manually) left the cluster but still can discover and reach cluster nodes.
---
 src/mria.erl        | 10 ++++++++++
 src/mria_config.erl | 19 +++++++++++++++++++
 src/mria_lb.erl     | 11 ++++++++---
 3 files changed, 37 insertions(+), 3 deletions(-)

diff --git a/src/mria.erl b/src/mria.erl
index dd57e48..b757d2c 100644
--- a/src/mria.erl
+++ b/src/mria.erl
@@ -35,6 +35,8 @@
         , cluster_nodes/1
         , cluster_status/1
         , is_node_in_cluster/1
+        , enable_core_node_discovery/0
+        , disable_core_node_discovery/0
         ]).
 
 %% Register callback
@@ -271,6 +273,14 @@ force_leave(Node) ->
             {error, node_not_in_cluster}
     end.
 
+-spec enable_core_node_discovery() -> ok.
+enable_core_node_discovery() ->
+    mria_config:set_core_node_discovery(true).
+
+-spec disable_core_node_discovery() -> ok.
+disable_core_node_discovery() ->
+    mria_config:set_core_node_discovery(false).
+
 %%--------------------------------------------------------------------
 %% Register callback
 %%--------------------------------------------------------------------
diff --git a/src/mria_config.erl b/src/mria_config.erl
index 61624e2..680ad10 100644
--- a/src/mria_config.erl
+++ b/src/mria_config.erl
@@ -32,6 +32,9 @@
         , load_config/0
         , erase_all_config/0
 
+        , set_core_node_discovery/1
+        , is_core_node_discovery_enabled/0
+
           %% Shard config:
         , set_dirty_shard/2
         , dirty_shard/1
@@ -247,6 +250,22 @@ set_extra_mnesia_diagnostic_checks(Checks) when is_list(Checks) ->
 get_extra_mnesia_diagnostic_checks() ->
     persistent_term:get(?mria(extra_mnesia_diagnostic_checks), []).
 
+-spec set_core_node_discovery(boolean()) -> ok.
+set_core_node_discovery(What) when What =:= true; What =:= false ->
+    case role() of
+        core ->
+            ok;
+        replicant ->
+            ok = application:set_env(mria, core_node_discovery, What)
+    end.
+
+-spec is_core_node_discovery_enabled() -> boolean().
+is_core_node_discovery_enabled() ->
+    case role() of
+        core -> false;
+        replicant -> application:get_env(mria, core_node_discovery, true)
+    end.
+
 %%================================================================================
 %% Internal
 %%================================================================================
diff --git a/src/mria_lb.erl b/src/mria_lb.erl
index efd4582..6e3fef5 100644
--- a/src/mria_lb.erl
+++ b/src/mria_lb.erl
@@ -314,11 +314,16 @@ lb_callback() ->
 
 -spec discover_nodes() -> [node()].
 discover_nodes() ->
-    DiscoveryFun = mria_config:core_node_discovery_callback(),
     case manual_seed() of
         [] ->
-            %% Run the discovery algorithm
-            DiscoveryFun();
+            case mria_config:is_core_node_discovery_enabled() of
+                true ->
+                    %% Run the discovery algorithm
+                    DiscoveryFun = mria_config:core_node_discovery_callback(),
+                    DiscoveryFun();
+                false ->
+                    []
+            end;
         [Seed] ->
             discover_manually(Seed)
     end.