Pack DXC native libs with generator #349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
added
enhancement ✨
Sergio0694
force-pushed
the
dev/generator-native-libs-pack
branch
2 times, most recently
from
051bf51 to
6667de5
Compare
Sergio0694
force-pushed
the
dev/generator-native-libs-pack
branch
from
6667de5 to
3ed7a22
Compare
Sergio0694
force-pushed
the
dev/generator-native-libs-pack
branch
from
3ed7a22 to
c8dac29
Compare
Sergio0694
force-pushed
the
dev/generator-native-libs-pack
branch
from
c8dac29 to
c79b6a2
Compare
No longer using embedded resources
Sergio0694
force-pushed
the
dev/generator-native-libs-pack
branch
from
c79b6a2 to
13fa144
Compare
|
Closing this, since it's blocked anyway. Can reopen when dotnet/roslyn#54899 is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #348
Description
This PR packs the DXC native libs (dxcompiler and dxil) so the generator can load them directly.
These are copied (and packed) into
Libraries\<RID>\relative to the generator assembly.