Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this still being maintained? #778

Open
tdtooke opened this issue Sep 10, 2021 · 5 comments
Open

Is this still being maintained? #778

tdtooke opened this issue Sep 10, 2021 · 5 comments

Comments

@tdtooke
Copy link

tdtooke commented Sep 10, 2021

Hi. I use this and I just successfully updated to bootstrap 5 on mine. If this is something that's still maintained I could fork it and do a proper pull request. Maybe have it give you the choices of bootstrap 4 and 5. Lots of improvements in bootstrap 5, especially with modals. I simply don't have the time to maintain anything so I'm not going to do a 'real' fork but I could update this one.

@Rajarshi07
Copy link

Did it work with bootstrap 5 without issues?

@tdtooke
Copy link
Author

tdtooke commented Oct 28, 2021

None that I can see. You do have to wade through a lot of code and change some things. And you have to include jquery-ui now. You also need to include popper if you want the tool tips to work. I'm considering doing a fork but someone else would have to maintain it.

Edit: I jut made a fork. Maybe I'll have my version running by Friday. I have to figure out how to commit to github and all that, plus I need to mod the original files, not just give you my site which wouldn't help either of us.

Edit: I think I have it all uploaded now. It's at https://github.com/tdtooke/bootstrap-calendar Let me know if it works. It does on my test server but who knows if I uploaded everything correctly.

Edit: I put in a pull-request for the changes I made so maybe if Serhiormano is still interested in keeping it going we can have the branch that actually has a demo out there to be updated. I'm hosting inside my company's intranet so I can't really have a demo.

Last Edit: I removed that pull request. I had some bugs in that one I had to fix first. It appears to be fully up now but I want to spend more time 'kicking the tires' before I put in a pull request. Plus the way I solved some problems was kinda 'hacky' I wish I could just put up my site but it would take too long to sanitize it and create fake entries for the calendar.

@lucc
Copy link

lucc commented Mar 30, 2022

@Serhioromano are you still maintaining this repo? We also fixed a bug in our company that we could give back, but if you are not going to include it I am to lazy to send a PR.

@Neozxz
Copy link

Neozxz commented Mar 30, 2022 via email

@Serhioromano
Copy link
Owner

@lucc I am not actively maintaining this project, but usually go through PRs. I'll gladly accept it if it is packed properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants