Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] QK-Norm #82

Open
Tracked by #66
sohamparikh opened this issue Dec 3, 2024 · 0 comments
Open
Tracked by #66

[feat] QK-Norm #82

sohamparikh opened this issue Dec 3, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@sohamparikh
Copy link
Member

🧐 Problem Description

OLMoE applies RMSNorm to query and key projections for training stability, at the cost of 10% training throughput. See Figure 18 in OLMoE paper for the ablation. We would like to implement the same for apples-to-apples comparison

💡 Proposed Solution

Specify QK-norm in config transformers/config.py, and maybe modify the forward pass in attention.py::forward?

🔄 Alternatives Considered

No QK-norm, which would require a custom implementation in HF, or we go with the MixtralForCausalLM implementation. Might be a bit more risky

📈 Potential Benefits

Better training stability as indicated by the OLMoE ablations.

@sohamparikh sohamparikh added the enhancement New feature or request label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant