Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Inconsistent init_method_std in test_load_distributed_checkpoint_dp2 #88

Open
jlamypoirier opened this issue Dec 9, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jlamypoirier
Copy link
Collaborator

jlamypoirier commented Dec 9, 2024

🐞 Describe the Bug

test_load_distributed_checkpoint_dp2 fails with:

E           ValueError: Config diff:
E             init_method_std_embed`: `0.022` != `0.0625`
E             transformer.init_method_std`: `0.022` != `0.0625`
E             transformer.init_method_std_attn_proj`: `0.011` != `0.03125`
E             transformer.init_method_std_mlp_2`: `0.011` != `0.03125`
E             transformer.init_method_std_mlp_1`: `0.022` != `0.0625`
E             transformer.init_method_std_qkv`: `0.022` != `0.0625`

Must be some inconsistency between the config creation/loading methods. This bug is completely harmless since we're loading an already initialized checkpoint but could be hiding a bigger problem.
Likely reason: non-architecture config validated before loading the pretrained architecture, so the wrong architecture is used to set the defaults.

🔄 Steps to Reproduce

Run the test

🎯 Expected Behavior

Tests pass

@jlamypoirier jlamypoirier added the bug Something isn't working label Dec 9, 2024
@jlamypoirier jlamypoirier self-assigned this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant