Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Dump full configuration in experiment-dir #91

Open
RaymondLi0 opened this issue Dec 10, 2024 · 2 comments
Open

[feat] Dump full configuration in experiment-dir #91

RaymondLi0 opened this issue Dec 10, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@RaymondLi0
Copy link
Contributor

🧐 Problem Description

There are lots of parameters in fast-llm. Sometimes we want to double-check what defaults were used in a training run. Currently, we need to dig into the code to check the defaults value.

💡 Proposed Solution

Increase the verbosity of the configuration dumped in experiment-dir (instead of only the core and non-default values).
We could increase to FieldHint.feature or FieldHint.performance for example.

📈 Potential Benefits

Easily inspect all the parameters used for a given run.
Would also make it easier to re-use dumped configs in later runs (default values could change in future versions of fast-llm for example)

@RaymondLi0 RaymondLi0 added the enhancement New feature or request label Dec 10, 2024
@RaymondLi0
Copy link
Contributor Author

Although I can see why it's convenient to only look at the non-default values.
We could dump multiple configs with different levels of verbosity? Or would it be too much?

@jlamypoirier
Copy link
Collaborator

Although I can see why it's convenient to only look at the non-default values. We could dump multiple configs with different levels of verbosity? Or would it be too much?

The problem is there are already hundreds of parameters, and usually most of them are irrelevant, so a full config is an unreadable mess. I'm open to having two separate files though, ex. config.yaml and config_summary.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants