Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SwapAnimation Plugin #261

Open
chunhei37 opened this issue Aug 9, 2018 · 2 comments · May be fixed by #389
Open

SwapAnimation Plugin #261

chunhei37 opened this issue Aug 9, 2018 · 2 comments · May be fixed by #389
Labels
bug unintended behaviour

Comments

@chunhei37
Copy link

While I'm using the swap animation plugin, I found that when an item moves into an empty sortable container an uncaught TypeError will occur.

Uncaught TypeError: Cannot read property 'style' of undefined
at animate (plugins.js:322)
at lastAnimationFrame.requestAnimationFrame (plugins.js:300)
@owen-m1 owen-m1 added the bug unintended behaviour label Apr 5, 2019
@kilianso
Copy link

kilianso commented Mar 21, 2020 •
edited
Loading

I can confirm, that this is still an open bug. Here's a demo.
https://codepen.io/kilianso/pen/XWbYeWb

@owen-m1 is draggable still under active development or should i use sortablejs instead?

UPDATE

For those who still face this problem. Here is the same demo as above, but it uses sortablejs instead of draggable.

https://cdpn.io/kilianso/pen/KKpBOwm

@owen-m1
Copy link
Contributor

owen-m1 commented Mar 21, 2020

@kilianso I haven't contributed to Draggable in a while as I haven't had time and it looks like no one else has either.

You can use SortableJS or you could use Draggable with this library I made which is an extraction of the animation code of SortableJS, called Animatum.

@hamedbaatour hamedbaatour linked a pull request Apr 30, 2020 that will close this issue
Open
6 tasks
zjffun pushed a commit to zjffun/draggable that referenced this issue Jul 18, 2020
@hamedbaatour @zjffun
add checks before applying any styling
cedebc5 
Fixes Shopify#261
zjffun pushed a commit to zjffun/draggable that referenced this issue Jul 19, 2020
@hamedbaatour @zjffun
add checks before start a swap animation
313339e 
Fixes Shopify#261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug unintended behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SwapAnimation: add checks before applying any styling
3 participants
@chunhei37 @kilianso @owen-m1