Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] eslint-plugin-jest installed unecessarily #2430

Open
tim-millar opened this issue Jan 12, 2023 · 0 comments
Open

[BUG] eslint-plugin-jest installed unecessarily #2430

tim-millar opened this issue Jan 12, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@tim-millar
Copy link

Describe the bug

We are using the hydrogen eslint plugin to lint our hydrogen project. We are also using vitest for unit testing (per the recommendations in the docs). When I run eslint in the project, it errors because it can't determine the jest version we're running - even though jest isn't installed or configured.

Screenshot 2023-01-12 at 17 24 15

After digging a bit, it seems as though eslint-plugin-hydrogen installs eslint-plugin-jest as a dependency. Since the intention seems to be for hydrogen projects to prefer vitest over jest, I'm guessing that this the result of some kind of oversight. Perhaps it should have been installed as a development dependency instead?

Screenshot 2023-01-12 at 17 34 43

Thanks

@tim-millar tim-millar added the bug Something isn't working label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant