Add an optional limit argument to split filter #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! The typo in the PR title should be corrected to "Optional" I guess. @gooroodev, can you review this too please? |
ahangarha
changed the title
ianks
reviewed
Aug 15, 2024
| def split(input, pattern) | ||
| input.to_s.split(pattern.to_s) | ||
| def split(input, pattern, limit = nil) | ||
| limit = limit.respond_to?(:to_i) ? limit.to_i : 0 |
There was a problem hiding this comment.
I think we should use Liquid::Utils.to_integer here.
There was a problem hiding this comment.
Oh! I didn't know. I will update the PR ASAP.
There was a problem hiding this comment.
As per my research Liquid::Utils.to_integer might not be helpful since it doesn't return 0 if an empty string gets passed. Not sure if I am too sensitive here or the 'to_integer' method needs some update.
What do you suggest? @ianks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional limit argument to the
splitfilter in Liquid to make it work similar to the Rubysplitmethod.Closes #1800