Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Faraday 2.x #68

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Upgrade to Faraday 2.x #68

merged 2 commits into from
Jul 12, 2023

Conversation

Ginja
Copy link
Member

@Ginja Ginja commented Jul 11, 2023

  • Update default Ruby installation to 2.7.2. Keeping the required_ruby_version set to '>= 2.6' as this gem does still work with 2.6.6.
  • Cherry-picked @cuchi's commit from their PR. It's fairly common now for other gems to require Faraday > 2 and that conflicts when those gems are used in conjunction with oktakit.

🎩 tests pass locally

Finished in 0.15587 seconds (files took 0.19447 seconds to load)
136 examples, 0 failures

@Ginja Ginja force-pushed the loosen-faraday-version-constraints branch from 762b878 to 8fd0cce Compare July 11, 2023 22:48
@Ginja Ginja changed the title Loosen Faraday Version Constraints Upgrade to Faraday 2.x Jul 11, 2023
@rporrasluc
Copy link
Contributor

rporrasluc commented Jul 12, 2023

Hello @Ginja, as I have commented via Slack:

In principle changes look good, however, all applications using oktakit will need to get faraday bumped. Can we set the gem so faraday 1 is still supported while we also allow other versions? Something like spec.add_dependency('faraday', '>= 0.17.3', '< 3')?

From what I can see in this Gemfile.lock as example it's very common to gem defining the dependency like that.

You might need to create version conditioned code like this from octokit.

What do you think?

@Ginja
Copy link
Member Author

Ginja commented Jul 12, 2023

As per our discussion with @ltk we'll keep the minimum Faraday requirement at version 2 to try and prevent similar issues that we experienced in past PRs. Afterwards I'll cut a new major release (i.e. 1.0.0).

@Ginja Ginja merged commit 8aaea76 into master Jul 12, 2023
6 checks passed
@Ginja Ginja deleted the loosen-faraday-version-constraints branch July 12, 2023 17:23
@Ginja Ginja mentioned this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants