Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ReactNode in annotation.content.content #1725

Open
philschoefer opened this issue Sep 19, 2024 · 0 comments
Open

Allow ReactNode in annotation.content.content #1725

philschoefer opened this issue Sep 19, 2024 · 0 comments
Assignees

Comments

@philschoefer
Copy link
Contributor

philschoefer commented Sep 19, 2024

Feature request summary

Allow annotations to contain ReactNodes in the content property. Currently we only allow for string.

Rationale

The admin is hacking react nodes into the annotation as part of the web vitals reports and we will also need this for the UA annotations feature @LevonCross is building out (hover over the "1" in the prototype).

We are also using this for annotations in UA to be able to group annotations that fall on to the same key.

Potential other solution to this could be to make Polaris Viz smarter in the sense that it can group annotations on the same key (e.g. if there are other concerns with changing it to ReactNode). In this case we would need to expand the existing Annotation type so it can take in all the props necessary for the updated designs.


🌟 Feature requests that are not yet planned will be closed. We then use the issue’s 👍 upvotes to track and set priorities. See the contribution guidelines for more information.

@envex envex self-assigned this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants